The Open Anzo Project

Semantic Application Middleware

Ticket #94 (closed defect: fixed)

Opened 1 year ago

Last modified 1 year ago

TestUpdates swallowing test failures

Reported by: jpbetz Assigned to: mroy
Priority: major Milestone: 3.0 milestone1
Component: openanzo Version: 3.0
Keywords: testing stability Cc:

Description (Last modified by mroy)

Running org.openanzo.test.client.TestUpdates
Exception in thread "Thread-13" junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:47)
        at junit.framework.Assert.assertTrue(Assert.java:20)
        at junit.framework.Assert.assertTrue(Assert.java:27)
        at org.openanzo.test.client.TestUpdates$8.run(TestUpdates.java:596)
        at java.lang.Thread.run(Thread.java:613)
Exception in thread "Thread-14" junit.framework.AssertionFailedError: null
        at junit.framework.Assert.fail(Assert.java:47)
        at junit.framework.Assert.assertTrue(Assert.java:20)
        at junit.framework.Assert.assertTrue(Assert.java:27)
        at org.openanzo.test.client.TestUpdates$9.run(TestUpdates.java:640)
        at java.lang.Thread.run(Thread.java:613)
Tests run: 12, Failures: 0, Errors: 0, Skipped: 0, Time elapsed: 41.607 sec

because exceptions happen in thread they never bubble up to junits catch clauses, where they need to get to be recorded as test failures.

Change History

11/04/07 11:26:17 changed by jpbetz

claiming bug

11/08/07 01:27:52 changed by jpbetz

(In [745]) re #94 reviewer: mroy

Clean up of TestUpdates?. Improve JMS message logging (info level) and correlationId propagation. Note: There is still a bug exposed by TestUpdates?, the test for which is commented out.

11/08/07 12:38:43 changed by mroy

  • status changed from new to closed.
  • resolution set to fixed.

Work looks fine. A lot of the extra passing of the correlation id is not longer needed once the ServiceContainer code is merged in, since all operations pass along an IOperationContext, which can store information about the calls as they traverse the anzo layer cake.

11/08/07 13:38:45 changed by jpbetz

  • status changed from closed to reopened.
  • resolution deleted.

reopening. Not quite done with this one yet.

11/08/07 16:07:04 changed by jpbetz

(In [751]) re #94

Fix bug in TestUpdates? test. Make ResourceCache? LRUCaches thread safe in passing: simplify some code in DatasetServiceEventManager?

11/08/07 16:14:48 changed by jpbetz

  • owner changed from jpbetz to mroy.
  • status changed from reopened to new.

reassigning for review. Only 751 is unreviewed. Thanks!

11/08/07 18:47:04 changed by mroy

Looks fine.

11/18/07 20:30:18 changed by mroy

  • status changed from new to closed.
  • resolution set to fixed.
  • description changed.
Copyright © 2007 - 2008 OpenAnzo.org